Copilot commented on code in PR #904:
URL: https://github.com/apache/maven-wagon/pull/904#discussion_r3740651320
##########
wagon-providers/wagon-ssh/src/main/java/org/apache/maven/wagon/providers/ssh/jsch/ScpWagon.java:
##########
@@ -54,6 +55,12 @@
public class ScpWagon extends AbstractJschWagon {
private static final char COPY_START_CHAR = 'C';
+ /** scp acknowledgement byte for a recoverable error, what OpenSSH sends
for a missing file */
+ private static final int SCP_WARNING = 1;
+
+ /** scp acknowledgement byte for a fatal error */
+ private static final int SCP_ERROR = 2;
Review Comment:
The constant documentation says ack code 1 is a "recoverable error" /
"warning", but the wagon treats it as an error and throws immediately. This
makes the comment misleading for future maintainers; please describe the
semantics without calling it a warning/recoverable.
This issue also appears on line 232 of the same file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
