wilx opened a new pull request, #3417:
URL: https://github.com/apache/maven-surefire/pull/3417
Fixes #862.
## Summary
Failsafe 3.3.1 stopped writing a summary file when an integration-test
execution runs no tests. This is intentional, but `VerifyMojo` still tried
to read every path configured through `summaryFiles`, causing verification
of POM modules to fail with `FileNotFoundException`.
This change:
- filters configured summary files to those that actually exist;
- logs each missing summary file at DEBUG level;
- retains the normal failure when an existing summary reports test failures;
- adds unit coverage for entirely missing and mixed existing/missing
summaries;
- adds an integration test reproducing the POM-module failure from #862.
## Validation
- `mvn clean install` with JDK 17: passed (all 17 reactor modules).
- `mvn -Prun-its clean install` with JDK 17: passed (760 tests,
0 failures, 0 errors, 153 skipped).
- Focused `VerifyMojoTest` unit tests: 5 tests passed.
- `Surefire862MissingSummaryFilesIT`: 1 integration test passed.
- The reproducer linked from #862 succeeds with the locally built snapshot.
The JDK 8 build in this environment is blocked by the unrelated existing
`ProcessCheckerTest.shouldHavePidAtBegin` start-time assertion; the same test
and both complete builds pass with JDK 17.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean install` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean
install`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
