gnodet commented on code in PR #12657:
URL: https://github.com/apache/maven/pull/12657#discussion_r3741936989
##########
pom.xml:
##########
@@ -1046,12 +1046,26 @@ under the License.
</execution>
</executions>
</plugin>
+ </plugins>
+ </build>
+ </profile>
+ <profile>
+ <id>maven-configuration</id>
+ <activation>
+ <property>
+ <name>skipConfiguration</name>
+ <value>!false</value>
Review Comment:
The `<value>!false</value>` inverts the skip semantics. With this value:
- `-DskipConfiguration=true` → profile stays **active** (wrong — should skip)
- `-DskipConfiguration=false` → profile becomes **inactive** (wrong — should
not skip)
Verified against `PropertyProfileActivator.java` lines 80-89: `!false` means
"activate when property value ≠ false", so `true` ≠ `false` keeps it active.
The standard Maven skip convention (`skipTests`, `maven.javadoc.skip`, etc.)
expects `true` to mean "skip". The correct value is `!true`:
```suggestion
<value>!true</value>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
