elharo commented on code in PR #405:
URL: https://github.com/apache/maven-help-plugin/pull/405#discussion_r3743537568
##########
src/main/java/org/apache/maven/plugins/help/EffectivePomMojo.java:
##########
@@ -197,6 +197,16 @@ private void writeEffectivePom(MavenProject project,
XMLWriter writer) throws Mo
// This removes the XML declaration written by MavenXpp3Writer
String effectivePom = prettyFormat(sWriter.toString(), null, true);
+ // MavenXpp3Writer omits packaging when it is null or "jar" (the
default).
+ // Ensure it is always present so users can see the effective
packaging value.
+ if (pom.getPackaging() == null || "jar".equals(pom.getPackaging())) {
+ String packaging = pom.getPackaging() != null ? pom.getPackaging()
: project.getPackaging();
+ String packagingTag = " <packaging>" + packaging + "</packaging>";
+ if (!effectivePom.contains(packagingTag)) {
+ effectivePom = effectivePom.replace("</version>" + LS,
"</version>" + LS + packagingTag + LS);
Review Comment:
Good point and a good reminder of why regexes are dangerous when processing
XML. There are other failure modes here too. I might take a whirl at fixing
this with some real XML.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
