wilx opened a new pull request, #416:
URL: https://github.com/apache/maven-help-plugin/pull/416

   ## Summary
   
   Fixes #327 for the Maven 3 maintenance line.
   
   `help:evaluate` can receive model collections implemented by Maven's 
internal `ModelMerger.MergingList`. XStream does not recognize that 
implementation as a collection and falls back to reflective serialization, 
which fails when it tries to access `AbstractList.modCount` on recent JDKs.
   
   This change registers a collection converter that accepts every `Collection` 
implementation and aliases the concrete runtime list class so the existing XML 
root name is preserved. The evaluated list is serialized directly without 
copying it.
   
   The commits are intentionally split: the first adds the regression IT and 
fails with the reflection error; the second applies the fix.
   
   ## Validation
   
   - `JAVA_HOME=/opt/jdks/latest-21 /opt/maven/latest/bin/mvn -Prun-its 
-Dinvoker.test=evaluate-model-collections clean verify`
   - `JAVA_HOME=/opt/jdks/latest-21 /opt/maven/latest/bin/mvn -Prun-its clean 
verify` — 22 unit tests and all 35 ITs passed
   
   ## Checklist
   
   - [x] This pull request addresses one issue without unrelated changes.
   - [x] The description explains what changed, how, and why.
   - [ ] Each commit has a meaningful subject line and body. Commit subjects 
are meaningful; no commit bodies were added.
   - [x] A regression integration test fails without the runtime change.
   - [x] `mvn verify` was run successfully.
   - [x] The integration tests were run successfully.
   
   - [ ] I hereby declare this contribution to be licenced under the Apache 
License Version 2.0, January 2004.
   - [ ] In any other case, an Apache Individual Contributor License Agreement 
has been filed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to