slachiewicz opened a new pull request, #160: URL: https://github.com/apache/maven-jarsigner-plugin/pull/160
## Summary - Migrate all 6 JUnit 4 test files to JUnit 5 (Jupiter): `org.junit.Test`/`Before`/`After`/`Rule` -> Jupiter equivalents, `TemporaryFolder` -> `@TempDir`, `@Test(timeout=...)` -> `@Timeout`, `org.junit.Assert` -> `org.junit.jupiter.api.Assertions` (reordering the one message-first `assertTrue` call to match the new signature). - Replace the `junit:junit` dependency with `org.junit.jupiter:junit-jupiter`, version-managed via the `junit-bom` import already provided by `maven-parent` (49), matching the pattern used in the sibling `maven-jlink-plugin`. - Add an explicit `org.hamcrest:hamcrest:3.0` test dependency: JUnit 4 previously pulled in `hamcrest-core` transitively, which this module relies on directly (`CoreMatchers`, `MatcherAssert`, `TypeSafeMatcher`, `Description` in `RequestMatchers.java` and several tests). - No load-bearing JUnit 4 usage was found (no `AbstractMojoTestCase`/`MojoRule`, no Ant `<junit>` task, no `suite()` method), so this is a full, mechanical migration with no leftover JUnit 4 files. ## Test plan - [x] `mvn -B test` before migration: `Tests run: 48, Failures: 0, Errors: 0, Skipped: 0` (surefire auto-detected `JUnit4Provider`) - [x] `mvn -B test` after migration: `Tests run: 48, Failures: 0, Errors: 0, Skipped: 0` (surefire auto-detected `JUnitPlatformProvider`, confirming real JUnit 5 execution) - [x] `mvn -q -B spotless:apply` / `mvn -q -B spotless:check` clean - [ ] CI green Generated-by: Claude Opus 5 (1M context) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
