slachiewicz opened a new pull request, #230: URL: https://github.com/apache/maven-ejb-plugin/pull/230
`MavenProjectBasicStub` was calling the static `PlexusTestCase.getBasedir()` helper — the last direct reference to the JUnit 3-era class in this repo. It now calls `PlexusExtension.getBasedir()` from `plexus-testing`. No POM change was needed: `junit-jupiter-api` and `junit-vintage-engine` are already declared here, which is why `EjbHelperTest` and `IncludesExcludesTest` were able to run as Jupiter already. The call is left qualified rather than static-imported, to stay consistent with the same change in maven-rar-plugin, where the stub's own `getBasedir()` override makes an unqualified call recurse infinitely. No such override exists here, but the two stubs are close enough that they should read the same way. **Not addressed here:** `EjbMojoTest` still extends `AbstractMojoTestCase`, which extends `PlexusTestCase` inside maven-plugin-testing-harness. That inheritance lives in the harness artifact, not in this repo. ### Verification `mvn test` before and after: `Tests run: 36, Failures: 0, Errors: 0, Skipped: 0`, with the same per-class breakdown (EjbMojoTest 19, EjbHelperTest 10, IncludesExcludesTest 7). `spotless:check` clean. Draft until CI confirms. Generated-by: Claude Opus 5 (1M context) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
