slachiewicz opened a new pull request, #1641:
URL: https://github.com/apache/maven-site/pull/1641

   `content/xdoc/index.xml.vm` is the maven.apache.org home page and the last 
ordinary xdoc content page in this repository. It becomes 
`content/markdown/index.md`, still rendering to `index.html`.
   
   The page contained no Velocity at all, so it drops the `.vm` suffix.
   
   Two things needed care:
   
   * **The layout table** leans on `rowspan` and on inline `style` for the 
heading cells, neither of which a Markdown table can express, so it is carried 
over as inline HTML. Doxia parses the block back into the same table events the 
xdoc parser produced and re-emits it with the attributes intact -- the 
three-by-three layout is byte-for-byte the same.
   * **The Apache Events banner** has to sit on the same line as the sentence 
that follows it. On a line of its own, the anchor tag opens a raw HTML block 
that swallows the rest of the paragraph and leaves two Markdown links unparsed 
on the page.
   
   ### Verification
   
   `mvn site` was run on `master` and on this branch and the generated HTML 
compared:
   
   - the three anchor ids on the page -- `#Welcome_to_Apache_Maven`, 
`#How_to_Get_Support`, `#Apache_Software_Foundation` -- are unchanged, so no 
deep link into the home page breaks
   - the page title, `meta name="author"`, visible text and every link target: 
identical
   - **all 264 other pages of the site: identical**
   - the raw markup differs only in whitespace, in a `<tbody>` Doxia now emits 
around the table, and in two pairs of straight quotes that Markdown renders 
curly (`"About Maven"`, `"cookbook"`)
   
   ### Please do not squash
   
   The rename is a separate commit so `git log --follow` keeps working on a 
page with fifteen years of history. Squashing collapses it back into a delete 
plus an add.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to