slachiewicz opened a new pull request, #842:
URL: https://github.com/apache/maven-shade-plugin/pull/842
Follow-up to the FML → Markdown FAQ conversion, which is already merged here.
### `<a id>` instead of `<a name>`
**maven-site-plugin 3.21.0 strips the `name=` attribute from an inline HTML
anchor; 3.22.0
keeps it.** On 3.21.0 every anchor on the page is lost silently, on a green
build with
`mvn site` exiting 0. This repo builds with a parent that pulls 3.22.0, so
the page is
correct as it stands — but `<a id>` is the form that survives either way,
and it is the
right one regardless:
- `Xhtml5BaseParser` reads `Attribute.ID` first and only falls back to
`NAME`, so `id=` is
the primary path.
- `name=` on `<a>` is obsolete in HTML5.
Anchors stay on their own line; folding one into the heading text suppresses
the section's
own generated id.
### Verification
Rendered `faq.html` before and after this change:
- the anchor set is unchanged, and still a **superset** of every anchor the
original FML
page served, so no deep link changes;
- the `<head>` is byte-identical;
- the visible text matches the FML original word for word;
- the site log reports no `used more than once` anchor warning.
`target/site` was deleted before each build and the page confirmed
regenerated, so this is
not a stale-output pass.
<sub>Drafted with Claude — please verify</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
