slachiewicz commented on PR #218:
URL: https://github.com/apache/maven-parent/pull/218#issuecomment-5245537033
Rebased onto master (was 257 behind, `22128a5` → `4499732`) and added a
second commit aligning the template with the page it replaces. Force-pushed —
the original commit is `22128a5` if you want to compare.
**Rebase conflicts**, both stale-branch artifacts rather than real
disagreements:
- The properties block: master has since moved to junit5 5.14.4 and a newer
`outputTimestamp`, and no longer defines `version.maven-fluido-skin` or
`version.maven-site-plugin` at all. I took master's side and dropped the
fluido-2.0.0 / site-plugin-3.21.0 / junit / timestamp edits, since they were
incidental to the template. Shout if any of them was deliberate.
- `pluginManagement`: master added an `apache-rat-plugin` block at the same
insertion point as `maven-remote-resources-plugin`. Kept both.
Also updated the two `44-SNAPSHOT` references — the bundle coordinate is now
`${project.version}`.
**The alignment commit is the part worth reviewing.** The template rendered
```
<a id="Apache_Maven_Parent_POM_50-SNAPSHOT">
```
and no `#Files`. That anchor carries the version, so it changes on every
release — it is the anchor the 2023 refresh replaced with the stable `#Files`,
and ~55 components already publish `#Files` today. Adopting the template as it
stood would have broken that anchor everywhere at once.
Fixing the heading pulled in the rest of the divergence: the template was
written from the pre-refresh prose, so it also carried the old "verify the
signature" paragraph instead of "verify the integrity", dropped the emphasis
and the "strongly recommended to use the latest release version" line, and
pointed the artifact at `closer.lua?action=download` rather than `dlcdn`
([MNGSITE-505](https://issues.apache.org/jira/browse/MNGSITE-505), mirrors
retired). The table row was also missing its leading pipe.
I have left `$downloadDirectory` / `$downloadArtifactId` exactly as you
designed them, and added `$sourceRelease` only to collapse a ~900-character row.
Verified: built `docs/` from the template and from the xdoc page in #593,
then diffed the two rendered `download.html` files — anchors, download hrefs
and visible text are identical, word for word.
One thing to decide: #593 refreshes `docs/src/site/xdoc/download.xml.vm`,
which this PR deletes. Happy to close #593 as superseded, or land it as the
stopgap while this one settles — your call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
