arimu1 commented on code in PR #1630: URL: https://github.com/apache/maven-site/pull/1630#discussion_r3755107402
########## content/markdown/whatsnewinmaven4.md: ########## @@ -152,9 +152,29 @@ the [live coding by Maven maintainer Karl Heinz Marbaise at IntelliJ IDEA Conf 2 **Note**: With Maven 4, it's also possible to exclude dependencies that are declared by BOMs using the existing `<exclusions>` element. -Also note that in Maven 4, importing BOMs with a classifier is now possible. -Therefore, the Maven team suggests that project BOMs should be generated as classified artifacts, using the -`<bomClassifier>` element. +Also note that in Maven 4 (model version 4.1.0 and later), importing BOMs with a classifier is possible by using the +standard `<classifier>` element on the import dependency: + +```xml +<dependencyManagement> + <dependencies> + <dependency> + <groupId>org.example</groupId> + <artifactId>example</artifactId> + <version>1.0.0</version> + <type>pom</type> + <classifier>bom</classifier> + <scope>import</scope> + </dependency> + </dependencies> +</dependencyManagement> +``` + +There is no dedicated `<bomClassifier>` element in the POM model or XSD. Review Comment: Thanks @elharo — good call. Rewrote that note to state only the correct behavior: classified BOM artifacts are attached with a classifier (e.g. via a BOM-building plugin), and consumers import them with the standard `<classifier>` element as in the example above. Removed the “what doesn’t exist” phrasing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
