slachiewicz opened a new pull request, #672: URL: https://github.com/apache/maven-doxia-sitetools/pull/672
Fixes #671. `MultiPageSinkFactory` takes the report output directory instead of a `MavenReport`, which is the only thing the site plugin's copy uses it for and the only thing that would have dragged Maven Reporting API into doxia-site-renderer. `MultiPageSubSink` has a package-private constructor: the factory is the only thing that creates one. Whether to unify the two consumers' "merge each sub-sink into the site" loops is left alone — they differ in logging and in where they take the output encoding from, and that is a separate call. Marked `@since 2.2.0`, since a new public type is not a patch release; happy to change it if the next release is numbered differently. Both consumers switch over only once this is released, so nothing breaks in the meantime: - maven-site-plugin `ReportDocumentRenderer` — delete both nested classes - maven-reporting-impl `AbstractMavenReport` — delete the copy added in apache/maven-reporting-impl#244, which carries a TODO pointing here Verified: `mvn -pl doxia-site-renderer test` → 21 passed. Reinstating the unguarded `substring` fails `subpageWithoutAnExtensionIsTakenAsIs` with the `StringIndexOutOfBoundsException` from #671. <sub>Drafted with Claude — please verify</sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
