slachiewicz opened a new pull request, #678:
URL: https://github.com/apache/maven-doxia-sitetools/pull/678

   `SiteToolTest` resolves the Fluido skin and parent site descriptors from 
Central. It assembles its own `RepositorySystemSession`, so Maven's offline 
setting never reaches it — running `mvn -o` still went to the network and still 
populated `target/local-repo`, which I confirmed by wiping that directory and 
watching six files reappear under `-o`. An offline build could not pass.
   
   The build now hands the setting to the test JVM and the class stands aside 
when it is set. That goes through `argLine` rather than 
`systemPropertyVariables`, because the latter takes Strings and 
`settings.offline` interpolates as a `Boolean` — surefire rejects it with 
`Cannot assign configuration entry ... of type java.lang.Boolean to property of 
type java.lang.String`.
   
   Verified: online, all 11 tests run and none skip; with `-o`, all 11 skip and 
nothing is written to `target/local-repo`.
   
   Note this adds a `<build>` section to `doxia-integration-tools/pom.xml`, 
which #677 also does — whichever lands second will want a trivial rebase. Happy 
to do that once the other merges.
   
   *This change was created with AI assistance.*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to