Hiteshsai007 commented on PR #12745: URL: https://github.com/apache/maven/pull/12745#issuecomment-5314869200
Thanks for the thorough review process, @gnodet! I'm glad we've ironed out the edge cases. I've just pushed two commits to address the final non-blocking suggestions: 1. **Test for `DefaultArtifactDescriptorReader` remap logic**: Added `DefaultArtifactDescriptorReaderTest` in `maven-impl` that uses reflection to directly test the private `convert` method. It verifies that when `remapCompileToApi = true`, both `compile` and empty (`""`) scopes are correctly remapped to `api`. It also verifies that they remain untouched when `remapCompileToApi = false`. 2. **Profile traversal test**: Added `testApiScopeInProfileRequires410()` in `MavenModelVersionTest` to ensure that an `api` scoped dependency explicitly declared inside a `<profile>` successfully forces the model version to `4.1.0`. 3. **Stale comments**: Updated the comments in `DefaultConsumerPomBuilder` from `"Only keep transitive scopes"` to `"Only keep consumer-visible scopes (compile, api, runtime)"` to accurately reflect the new semantics where `compile` is non-transitive but still consumer-visible. Thanks again for the guidance! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
