slachiewicz opened a new pull request, #1082:
URL: https://github.com/apache/maven-doxia/pull/1082

   The javadoc on `AbstractParser#getBasedir()` has carried an `@deprecated` 
tag since DOXIA-373 was raised, but without the annotation no caller ever saw a 
warning. Anyone subclassing `AbstractParser` could reach for it and never learn 
it does not work in multi-module builds.
   
   Adding the annotation is binary-compatible — japicmp passes against the 
2.0.0 baseline — so this fits the 2.x line, unlike removing the method.
   
   **One judgement call worth your view.** This surfaces four warnings inside 
Doxia itself, all at the `MacroRequest` construction in the APT, FML, xdoc and 
XHTML5 parsers. I left them in place rather than adding `@SuppressWarnings`: 
there is no replacement for the basedir those parsers need, and silencing the 
warnings would hide DOXIA-373 in the one codebase that can actually fix it. 
`AptParser` already carries a comment saying as much. If you would rather the 
build stayed quiet, suppressing at those four sites is a one-line change each — 
say the word.
   
   Verified: `mvn clean verify` → 667 tests pass, japicmp clean, and the only 
new warnings are the four expected call sites.
   
   *This change was created with AI assistance.*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to