slachiewicz commented on PR #1017: URL: https://github.com/apache/maven-doxia/pull/1017#issuecomment-5326539887
Thanks for this, and sorry it sat so long. I tried to reproduce the instability before rebasing, and could not. `MarkdownParserTest#htmlContent` on current master: - 15 consecutive runs on JDK 21 — no failures - JDK 11 and JDK 25 — pass - the CI matrix on master covers ubuntu/macOS/Windows across JDK 8, 17, 21 and 25, and is green Flexmark parses a fixed input file here, so the event stream looks deterministic rather than environment-dependent. If you have a setup where it does vary, I would like to see it — that would be a real parser bug worth fixing at the source rather than in the assertions. Setting that aside, the change trades away coverage the test currently has: events inside `tableRows` are skipped instead of asserted, so a genuine regression in whitespace or `tbody` handling would no longer be caught, and dropping `assertFalse(it.hasNext())` means trailing unexpected events stop failing. The `void` to `public void` change is also not needed under JUnit 5. Unless you can still reproduce the flakiness, I would suggest closing this. Happy to be shown otherwise. *This comment was created with AI assistance.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
