slachiewicz commented on PR #623: URL: https://github.com/apache/maven-doxia-sitetools/pull/623#issuecomment-5326556448
Summary of where this stands, since the threads are spread across two days in March and the PR has been quiet since. **The change:** `SiteTool.DEFAULT_LOCALE` becomes configurable from system properties instead of being fixed at `Locale.ROOT`, using three properties mirroring the JVM's own `user.language` / `user.country` / `user.variant`. **Two review points, both from @kwin, neither yet resolved in the code:** 1. *Three properties or one.* @kwin asked for a single property parsed with `Locale#forLanguageTag`. @michael-o's reasons for three were consistency with the JVM and with the reverse of `Locale#toString()`, then offered: *"I can merge into one propert[y] and pull up the parse method into the interface as a static method."* Agreed in principle, not yet done. 2. *The `user` infix.* @kwin: *"the `user` infix is still not very reasonable, I would rather deviate from the JVM naming here."* @michael-o: *"Yep, had the same feeling. It was worth a try. Will work on a better draft end of week."* Also agreed, also not yet done. So both open points already have agreement on direction — this is waiting on a redraft, not on a decision. The last exchange (17 March) then moved to release timing and concluded this has no Doxia release implications. Two things worth noting for whoever picks it up: `new Locale(...)` is deprecated for direct construction in newer JDKs in favour of `Locale.of` or `forLanguageTag`, which points the same way as review point 1; and the current form silently yields `Locale.ROOT` when the properties are unset, which is the existing behaviour and worth keeping explicit in whatever replaces it. *This comment was created with AI assistance.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
