rmannibucau commented on PR #508:
URL: https://github.com/apache/maven-jar-plugin/pull/508#issuecomment-5361141133

   > IMO it's critical to support binary reproducibility for all JDKs since 
minimal 17, otherwise it'll be a regression.
   
   stating that for maven 4 java 17 bytecode is supported using a java 21 or 
more (to speak "LTS") doesn't sound crazy to me
   also agree it is reproducible only for the same JVM baseline (not even minor 
matching) so on my side it stays not critical since covered technically if well 
documented
   
   > like moditect for example
   
   ZipFileSystem#sync can be worth benching on a big jar (some thousands of 
classes), ideally it is very small compared to producing the zip (jar) itself 
but worth evaluating before thinking this is an option IMHO - since we know we 
can always do it right directly if needed and JDK version is a blocker (once 
again not for me)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to