slachiewicz commented on PR #179: URL: https://github.com/apache/maven-resolver-ant-tasks/pull/179#issuecomment-5380464194
Both points fixed, plus two follow-ons. - `7f6e373` — point 2: `test-reports` is deleted before each run. - `0b1c0b8` — the examples' own reports had that same staleness, one directory over. They sat in `targetDir` and were never cleaned; `installAndClean` doesn't cover it, since `<fail>` halts before `clean` on the run that matters. - `956b228` — #180 landed the `legacy-plain` + `outputDir` shape you flagged against `build.xml` last round, so example failures printed only the summary line. Same `failureProperty` + `<concat>` fix. - `a49057d` — `<test name='…'/>` named a single class, so a second test class was silently skipped; now a `<testclasses>` fileset. That one also needs `testBuildDir` deleted first: the fileset scans compiled classes, so a test whose source is gone still runs from its leftover `.class`. It failed a `run-its` pass on me before I spotted it. You predicted two of these in review before they existed, which is a decent hit rate. Verified: each fix has a counterfactual — a planted stale report or class alongside a genuine failure, compared with and without the change. A green run can't show any of it, since the `<concat>` is behind `if:set="test.failed"`. *This comment was created with AI assistance.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
