slachiewicz opened a new pull request, #697:
URL: https://github.com/apache/maven-checkstyle-plugin/pull/697
`resolverVersion` names four resolver artifacts, but `maven-resolver-spi`
and `maven-resolver-util` are not among them — they arrive transitively from
`maven-core` at 1.4.1. Raising the property therefore produces a mixed stack,
and `maven-resolver-impl` cannot be wired against a 1.4.1 spi:
```
null returned by binding at org.eclipse.sisu.wire.LocatorWiring
but DefaultRepositorySystemSessionFactory.repoSystem is not @Nullable
while locating org.eclipse.aether.RepositorySystem
```
That is what #691 hits — 9 of 10 `CheckstyleReportTest` cases error before
any assertion runs. It is an incomplete bump rather than an incompatibility.
Declaring the two missing artifacts at `${resolverVersion}` makes the
property mean what it says. The version stays at 1.4.1, so nothing changes
today.
Verified locally at both versions, `mvn verify -DskipITs`:
| resolverVersion | result |
|---|---|
| 1.4.1 (this PR) | BUILD SUCCESS, 26/26 |
| 1.9.27 (this PR + #691) | BUILD SUCCESS, 26/26 |
| 1.9.27 (#691 alone) | 9 errors |
Whether to then take #691 is a separate call: `mavenVersion` is 3.6.3, which
ships resolver 1.4.1, so the bump would test the plugin against a combination
no user runs. Pinning resolver to the Maven baseline and having dependabot
ignore it — as maven-surefire already does — is the alternative.
*This change was created with AI assistance.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
