slachiewicz commented on issue #1645: URL: https://github.com/apache/maven-site/issues/1645#issuecomment-5393758116
Yes — we knew the conversion wouldn't be entirely straightforward, and this is the kind of breakage only the rendered page shows. What I found after building everything locally: - #1652 fixes more than the diagrams. The Markdown parser turns each self-closing `<object/>` into an *unclosed* `<object>` and emits all seven `</object>` at the end of the body — so everything after the first diagram was hidden as object fallback content. With your change the whole page comes back. - While verifying it I found a second leftover from the xdoc conversion: raw `<head>` blocks are not honored by the Markdown parser — title/author leak as stray text at the top of the body and the pages fall back to the bare "Maven" browser title. This affects `scm.md` plus four more pages (`articles`, `repository/index`, `guides/mini/guide-naming-conventions`, `developers/mojo-api-specification`). #1653 moves that metadata to YAML front matter; it doesn't overlap with #1652, so the two merge in either order. - I swept the rest of the site: `scm.html` was the only page with the self-closing pattern, every other SVG is embedded via plain image syntax, and all referenced SVG files resolve. I'm also taking the root cause upstream to doxia-converter (issue + fix) so future conversions emit explicitly closed tags instead of this trap. Once these cleanups land, having everything in one Markdown tree should make the docs far easier to manage and refactor than the xdoc/apt mix ever was. *This comment was created with AI assistance.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
