elharo commented on code in PR #422:
URL: https://github.com/apache/maven-help-plugin/pull/422#discussion_r3843087688
##########
src/main/java/org/apache/maven/plugins/help/EffectivePomMojo.java:
##########
@@ -107,7 +107,13 @@ public void execute() throws MojoExecutionException {
}
StringWriter w = new StringWriter();
- String encoding = output != null ?
project.getModel().getModelEncoding() : System.getProperty("file.encoding");
+ String rawEncoding;
+ if (output != null) {
+ rawEncoding = project.getModel().getModelEncoding();
+ } else {
+ rawEncoding = System.getProperty("file.encoding");
Review Comment:
just use UTF-8; no reason to use system defaults to write an XML doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
