Neil-Tomar commented on code in PR #414:
URL: https://github.com/apache/maven-help-plugin/pull/414#discussion_r3845265367
##########
src/main/java/org/apache/maven/plugins/help/EffectivePomMojo.java:
##########
@@ -178,7 +178,7 @@ private boolean shouldWriteAllEffectivePOMsInReactor() {
* @throws MojoExecutionException if any
*/
private void writeEffectivePom(MavenProject project, XMLWriter writer)
throws MojoExecutionException {
- Model pom = project.getModel();
+ Model pom = project.getModel().clone();
Review Comment:
Sorry for the late reply again.
`Model` implements `Cloneable` and overrides `clone()`, but I couldn’t find
the class anywhere in the repo or elsewhere.
I’m not completely sure about all the details of this, but the test in this
PR fails without `clone()` and passes with it. So, at least in this case, the
project’s properties remain untouched.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
