slachiewicz commented on issue #1300: URL: https://github.com/apache/maven-site-plugin/issues/1300#issuecomment-5399025316
Implementation proposed in apache/maven-doxia-sitetools#684, since the breadcrumb code lives there rather than in this plugin. The trail is derived per document in `DefaultSiteRenderer.createDocumentVelocityContext` rather than during model assembly: `SiteModelInheritanceAssembler` runs once per project and has no notion of which page is rendering. Behind an opt-in `SiteRenderingContext.deriveBreadcrumbsFromMenu` flag, default off. That PR carries one assumption worth a second opinion: it takes `ref`, `inherit`, and `inheritAsRef` menus as already resolved by `DefaultSiteTool` before the model reaches the renderer. If that ordering does not hold, derivation finds nothing and the page renders as it does today, so the failure mode is a missing breadcrumb rather than a wrong one. Confirming it needs an end-to-end site build on this side. What remains here is the plugin-facing parameter, once the renderer flag settles. The name proposed above, `generateBreadcrumbsFromMenus`, should be reconciled with the renderer's `deriveBreadcrumbsFromMenu`. *This comment was created with AI assistance.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
