slachiewicz commented on PR #3285: URL: https://github.com/apache/maven-surefire/pull/3285#issuecomment-5399385466
Rebasing this on master stops at a decision rather than a merge conflict, so I left it alone. The branch predates the `ProcessChecker` refactor, and replaying it reverts master: it drops `implements ProcessChecker` and the `@Deprecated` marker from `PpidChecker`, removes the javadoc pointing at `ProcessHandleChecker`, and swaps `SYSTEM_PATH_TO_POWERSHELL` back to the WMIC32 and WMIC64 paths. There is also a modify/delete on `PpidCheckerTest.java`, which master deleted as part of the ProcessHandle work (#3252, reverted, reapplied as #3263) and this branch modifies. So the open question is whether WMIC support still belongs now that master reaches powershell through `ProcessChecker`, with `ProcessHandleChecker` preferred on Java 9+. That is yours to answer, and guessing at it in a rebase would have buried the question rather than raised it. *This comment was created with AI assistance.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
