slachiewicz commented on PR #447: URL: https://github.com/apache/maven-build-cache-extension/pull/447#issuecomment-5399474098
I rebased this branch onto master and force-pushed it, so CI can give a current verdict. Your previous head was `03c5dd0` if you want any of it back. Two things came out of the rebase that are worth knowing: The POM conflicted because master bumped assertj-core to 3.27.7 while this branch removes the dependency. I took this branch's side and dropped the block, which is what the change is for. The rebase then produced a branch that did not compile, and git never flagged it. Master added `getCleanSegmentForCliGoalIsEmpty` to `LifecyclePhasesHelperTest` after this branch was cut, and it asserts through assertj; that file merged cleanly, so the breakage only showed up at compile time. I converted the one `assertThat(cleanSegment).isEmpty()` to `assertTrue(cleanSegment.isEmpty())` in a separate commit — `assertTrue` was already imported and the neighbouring cases use plain JUnit. Revert that commit if you would rather write it differently. Verified locally with `mvn -DskipITs test`: `Tests run: 97, Failures: 0, Errors: 0, Skipped: 4`. *This comment was created with AI assistance.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
