slachiewicz commented on PR #12402: URL: https://github.com/apache/maven/pull/12402#issuecomment-5399838736
The 3298 unapproved files come from the scan reaching into the submodules, not from RAT 0.18 itself. Grouping the failure list from [run 32762008735](https://github.com/apache/maven/actions/runs/32762008735/job/97542802539) by top-level directory gives 2745 files under `its/`, 468 under `impl/`, 77 under `compat/`, and 6 under `apache-maven/`. Nothing in the root module's own tree is reported, and 3183 of the 3298 sit under some `src/test/resources`. Two things follow: - The `dir/**` to `dir` rewrite isn't the whole story. `src/test/resources*/**` and `src/main/appended-resources/licenses/**` kept their glob form and still fail to match, because the reported paths are reactor-relative (`/its/...`, `/impl/...`) while the patterns are written module-relative. Anchoring them at the reactor root is the direction to try; I haven't run that variant, so treat it as a hypothesis rather than a fix. - Dropping `.mvn/**` costs nothing here. Zero reported files sit under `.mvn`, which matches point 1 in your earlier comment. On the version question, apache/maven-apache-parent#587 bumps RAT to 0.18 in the ASF parent and is approved, and apache/maven-parent#598 previews 0.18 behind a `[17,)` profile so the JDK 8 matrix cell keeps 0.16.1. Neither touches `<excludes>`, so the migration can settle here on its own timeline. *This comment was created with AI assistance.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
