slachiewicz commented on PR #128:
URL:
https://github.com/apache/maven-shade-plugin/pull/128#issuecomment-5400450065
The fix looks right. `setPomFile` assigns the same `file` field as `setFile`
and only skips the `basedir` reassignment, so `getFile()` still returns the
reduced POM and install and deploy keep publishing it — the change drops the
side effect without changing what ships. It carries `@since 3.2.4`, and this
plugin requires 3.6.3, so the floor is clear.
One thing on the new IT guard. The lookbehind tests for `/target`, and a
Windows `basedir` ends in `\target`, so the rule passes there whether or not
the regression is present:
.*(?<!/target)$ against C:\proj\target -> matches, rule passes
.*(?<![/\\]target)$ against C:\proj\target -> no match, rule fails
The shared workflow's default `os-matrix` includes `windows-latest`, so a
third of the matrix runs the IT without the assertion doing anything. Accepting
either separator restores it.
*This comment was created with AI assistance.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
