desruisseaux commented on PR #1027: URL: https://github.com/apache/maven-compiler-plugin/pull/1027#issuecomment-5401231566
This pull request has not been merged yet for the following reasons: * It removes the `LOCALE` constant, while I would like to keep it. It is not because this constant is set to the `null` value that it is dead code. Replacing `null` by `Locale.JAPANESE` (for example) would have the expected effect: localize some messages to Japanese. Even if we are unlikely to change the `null` value to something else, the `LOCALE` constant is still useful for spotting easily the places where localization happens. * It introduces a new configuration parameter (`messageLogType`) with a new enumeration (`MessageLogType`), which I think overlaps with the configuration of logging framework. Especially since Guillaume has done work on Maven logging recently, I think we should try to reftrofit this feature as configuration of the logging framework. * It contains a `tryGetCompilerBundle()` which is very specific to JDK internal and which will be blocked by the JVM if Maven is modularized some day. I saw that Guillame has already done some modularisation experiments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
