gnodet commented on code in PR #12828:
URL: https://github.com/apache/maven/pull/12828#discussion_r3852460076
##########
its/core-it-suite/pom.xml:
##########
@@ -629,6 +632,54 @@ under the License.
<redirectTestOutputToFile>false</redirectTestOutputToFile>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>download-maven-distro</id>
+ <goals>
+ <goal>copy</goal>
+ </goals>
+ <phase>process-test-resources</phase>
+ <configuration>
+ <artifactItems>
+ <artifactItem>
+ <groupId>org.apache.maven</groupId>
+ <artifactId>apache-maven</artifactId>
+ <version>${maven-version}</version>
+ <classifier>bin</classifier>
+ <type>zip</type>
+ <destFileName>maven-bin.zip</destFileName>
+ </artifactItem>
+ </artifactItems>
+ <outputDirectory>${project.build.directory}</outputDirectory>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-antrun-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>unpack-maven-distro</id>
Review Comment:
The default `unpack-built-maven-distro` execution (defined in the base
`<build>` section) uses `${sessionRootDirectory}`, which is undefined under
Maven 3. Since you're adding a replacement extraction here, you also need to
disable the default — otherwise it runs first and fails.
Add before this execution:
```xml
<execution>
<id>unpack-built-maven-distro</id>
<phase>none</phase>
</execution>
```
This matches the pattern used by `maven-from-build`, `maven-from-repo`, and
`maven-distro` profiles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
