elharo opened a new pull request, #1367: URL: https://github.com/apache/maven-assembly-plugin/pull/1367
Fixes #1349. The FIXME comments in `AbstractLineAggregatingHandler` and `ComponentsXmlArchiverFileFilter` assumed the resource scan could be moved into plexus-archiver's `AbstractArchiver`, but the scan is required: the archiver runs its finalizers before scanning the added resources, so the file selectors are only applied while iterating. This PR: 1. **Replaces the misleading FIXME comments** with accurate documentation explaining why the resource iteration is necessary. 2. **Fixes the actual bug in `SimpleAggregatingDescriptorHandler`**: adds the missing resource scan whose absence caused its aggregated file to always be empty. 3. **Adds tests** for both `ComponentsXmlArchiverFileFilter` (verifying end-to-end aggregation from resource collections) and `SimpleAggregatingDescriptorHandler` (verifying aggregation and source exclusion). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
