elharo commented on code in PR #830:
URL:
https://github.com/apache/maven-shade-plugin/pull/830#discussion_r3856808303
##########
src/main/java/org/apache/maven/plugins/shade/resource/ApacheNoticeResourceTransformer.java:
##########
@@ -79,6 +79,19 @@ public class ApacheNoticeResourceTransformer extends
AbstractCompatibilityTransf
private static final String NOTICE_MD_PATH = "META-INF/NOTICE.md";
+ /**
+ * Uses the Maven project name when no project name was configured
explicitly.
+ *
+ * @param projectName the Maven project name
+ */
+ public void setProjectNameIfUnset(String projectName) {
Review Comment:
This still makes me queasy. My gut is that if someone calls this method, the
project name should be set.
Even if we keep the behavior as it, we need a better name.
setDefaultProjectName? setFallbackProjectName? maybe something else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
