AzazelSensei opened a new pull request, #1371:
URL: https://github.com/apache/maven-assembly-plugin/pull/1371

   The multimodule binary-inclusion example still needs `mvn clean package` so 
reactor modules exist before the assembly runs. That is a Maven 
aggregator/ordering constraint, not something unique to 2.0.
   
   I dropped the `2.0` qualifier from that note and left the rest.
   
   - [x] Your pull request should address just one issue, without pulling in 
other changes.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Each commit in the pull request should have a meaningful subject line 
and body.
   - [ ] Write unit tests that match behavioral changes, where the tests fail 
if the changes to the runtime are not applied.
   - [ ] Run `mvn verify` to make sure basic checks pass.
   - [ ] You have run the integration tests successfully (`mvn -Prun-its 
verify`).
   
   Docs-only, one sentence.
   
   - [x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
   Fixes #1370
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to