slachiewicz opened a new pull request, #1018: URL: https://github.com/apache/maven-enforcer/pull/1018
The `enforce-bytecode-version-multirelease` and `enforce-bytecode-version-multirelease-strict` IT projects pinned the log4j-api version twice: once in the POM and again inside the `verify.groovy` assertions. Every fixture upgrade therefore required touching both files in sync, and a POM-only change failed the IT verification. This PR moves the version into a `<log4j.version>` property and makes the assertions version-agnostic (anchored regexes on the `log4j-api` artifact), which decreases the maintenance cost of the ITs: - future fixture bumps become a one-line POM change and can never desynchronise the verification scripts - the tests keep asserting exactly the behaviour they exist for: analysis of multi-release JARs, `module-info` ignoring when `maxJdkVersion < 9`, and the strict-mode ban of classes above the maximum JDK - both fixtures are refreshed to log4j-api 2.25.5 Testing: - ran both IT projects locally against `maven-enforcer-plugin` 3.6.4-SNAPSHOT: `multirelease` passes, `strict` fails as required by its `invoker.buildResult = failure`, and the executed verify scripts pass in both cases - verified the refactored scripts pass with the property set to both `2.17.2` and `2.25.5` (property-only change) and still fail when the expected log lines are absent - [x] Your pull request should address just one issue, without pulling in other changes. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] You have run the integration tests successfully (`mvn -Prun-its verify`) for the affected projects. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
