goutamadwant opened a new pull request, #12877:
URL: https://github.com/apache/maven/pull/12877
Fixes #12754
## Summary
Remove the deprecated internal `XmlNodeBuilder` now that Plexus XML 4.2.0
provides the equivalent pull-parser implementation.
This change:
- delegates the Maven Embedder's `XmlNode` and `Xpp3Dom` conversions to
`Xpp3DomBuilder`
- removes the deprecated `XmlNodeBuilder` implementation
- changes `maven-xml`'s `plexus-xml` dependency from provided to test scope,
retaining it only for interoperability tests
- updates the reader template to use `XmlService.read`
- removes the obsolete HOCON reader template reference
- preserves the existing `XmlService` coverage and adds regression coverage
for both Embedder conversion paths
The replacement preserves the existing default trimming, attributes, child
values, and empty-element behavior.
## Verification
- `mvn -pl impl/maven-xml,compat/maven-embedder -am test`
- `mvn verify`
- `mvn -Prun-its clean verify` with Java 21
- Verified that `XmlNodeBuilder` is absent from the produced `maven-xml` JAR
- Verified that `plexus-xml` is absent from `maven-xml`'s compile dependency
tree
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Your pull request should address just one issue, without pulling in
other changes.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
Note that commits might be squashed by a maintainer on merge.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [x] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [x] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
