slachiewicz commented on PR #12842: URL: https://github.com/apache/maven/pull/12842#issuecomment-5450819484
Fixed the failing **MavenITmng4921QualityManagementTest** (all 9 integration-tests jobs failed with `expected: <SonarQube> but was: <null>`). **Root cause:** the IT evaluates the `project` expression and dumps the resulting `MavenProject` bean via reflection. It asserts on `project.qualityManagement.system`, but `MavenProject` had no `getQualityManagement()` accessor, so the element could never show up under that key. The model layer itself was fine — the generated `pom.properties` already contained the parsed and correctly merged/inherited value under `project.model.delegate.qualityManagement.*` (the 4.2.0 element only exists on the API model; the deprecated v3 compat `org.apache.maven.model.Model` is generated at version 4.0.99 and has no such field). **Fix (aac77f7e46):** added `MavenProject.getQualityManagement()` delegating to `getModel().getDelegate().getQualityManagement()` (same pattern already used by `getModules()` for the 4.1.0 `subprojects` element). A few existing methods were compacted to stay within the checkstyle `FileLength` limit of 2000 lines. Verified locally: the IT failed before the fix and passes after (`mvn -Prun-its verify -Dits.test=MavenITmng4921QualityManagementTest`), together with `impl/maven-core` unit tests (610 tests) and a batch of model-related ITs (mng-0836, mng-1052, mng-4450, mng-4572, mng-7228, mng-8523). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
