pzygielo commented on code in PR #151:
URL: https://github.com/apache/maven-acr-plugin/pull/151#discussion_r3888880777
##########
src/site/markdown/usage.md.vm:
##########
@@ -57,3 +57,59 @@ The ACR Plugin is used to package a JavaEE Application
Client module. There are
```shell
mvn acr:acr
```
+
+## Manifest entries
+
+The plugin does not invent a default `Main-Class`. If you do not set
+`archive.manifest.mainClass` (and you do not supply a custom manifest that
+already has one), the generated jar has no `Main-Class` entry.
+
+The Java EE specification still requires an Application Client to declare a
Review Comment:
Can you link that requirement?
If I'm not mistaken, glassfish accepts main-class as argument. So it's
definitely not required (at least for glassfish) to be declared in manifest.
https://jakarta.ee/specifications/platform/11/jakarta-platform-spec-11.0#a3179
(Note that that links to Jakarta EE, which is continuation and current name for
Java EE):
> If the .jar file contains a META-INF/MANIFEST.MF file with a Main-Class
attribute, or contains a META-INF/application-client.xml file, consider the
.jar file to be an application client module.
_**IF**_
Sounds like optional to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
