gnodet opened a new pull request, #12934: URL: https://github.com/apache/maven/pull/12934
## Summary Forward port of #12921 (squash-merged into `maven-4.0.x`) to `master`. Cherry-pick applied cleanly — both branches had identical `FastTerminal.java` prior to this fix. - Adds a pre-built `DumbTerminal` as fallback in `getTerminal()` so that **all** delegate methods are safe when called from the build thread during terminal construction - JLine 4.4.0's FFM provider initialization (`CLibrary.<clinit>`) can reach back through arbitrary terminal methods (`getSize`, `getName`, `encoding`, etc.) on the build thread — the previous per-method guards on `writer()` and `getType()` were insufficient - Adds 2 new tests exercising `getSize()` and `getName()` from builder/consumer callbacks Fixes #12912 ## Test plan - [x] All 4 `FastTerminalReentrancyTest` tests pass locally - [ ] CI passes on all platforms (ubuntu, macos, windows × JDK 17, 21, 25) 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
