elharo opened a new pull request, #12935:
URL: https://github.com/apache/maven/pull/12935

   Backport of #12932 (merge commit `8638f335`) to `maven-4.0.x`, fixing 
MNG-8174.
   
   A self-referencing property used in a plugin configuration attribute caused 
an NPE during interpolation because `interpolate()` could return `null` while 
recursing, and the guard `if (org != val)` would still call 
`setValue`/`setAttribute` with `null`.
   
   This backport:
   - Adds `&& val != null` to both `visit(Xpp3Dom)` setters in 
`StringVisitorModelInterpolator`.
   - Adds regression test `testRecursiveExpressionCycleInPluginConfiguration` 
asserting 1 model error and that the config attribute retains `${prop}`.
   
   Tested: full `StringVisitorModelInterpolatorTest` (19 tests) + 
`StringSearchModelInterpolatorTest` pass.
   
   Closes https://issues.apache.org/jira/browse/MNG-8174


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to