elharo opened a new pull request, #12941: URL: https://github.com/apache/maven/pull/12941
Fixes #10326 / [MNG-8749](https://issues.apache.org/jira/browse/MNG-8749). `org.apache.maven.api.services.model.PathTranslator` has exactly one implementation that is only used internally (in the `impl` package). This PR removes the interface from the public API and folds its single `alignToBaseDirectory(String, Path)` method directly into the internal `org.apache.maven.impl.model.DefaultPathTranslator` implementation. Changes: - Deletes `api/maven-api-spi/.../services/model/PathTranslator.java`. - `DefaultPathTranslator` no longer implements the interface; it now carries `alignToBaseDirectory` directly and is marked as an internal, non-public-API implementation. - Updates the four internal consumers to reference `DefaultPathTranslator` instead: - `DefaultModelInterpolator` - `DefaultModelPathTranslator` - `DefaultModelBuilder` - `DefaultProfileActivationContext` No external API callers are affected: the interface had no implementers outside the `impl` tree, and `maven-testing` (which manually wires these impl constructors) passes `new DefaultPathTranslator()` directly, which remains valid. Verified: full `maven-impl` unit test suite (610 tests, 0 failures) plus compilation of `maven-api-spi`, `maven-testing`, `maven-core`, and `maven-cli`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
