slachiewicz commented on PR #12955: URL: https://github.com/apache/maven/pull/12955#issuecomment-5470648505
Removed the `systemPath` change from this PR. It made `ArtifactDescriptorReaderDelegate` attach `LOCAL_PATH` only for workspace-resolved descriptors, which breaks `MavenITmng4379TransitiveSystemPathInterpolatedWithEnvVarTest`. That IT covers MNG-4379: a dependency resolved from a repository declaring its own `system`-scope dependency, with the `systemPath` interpolated from an environment variable. That is deliberate, long-standing behaviour and the change would have removed it. The remaining commits are unaffected and this is otherwise ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
