slachiewicz commented on PR #1297:
URL:
https://github.com/apache/maven-site-plugin/pull/1297#issuecomment-5471709719
@Copilot-pull-request-reviewer re: your 5 review comments on #1297. 1/
Malformed scm: URL: valid — catch IndexOutOfBoundsException in
extractComparableUrl, fallback to original URL so build doesn't crash. 2/
Scheme decision at call site: already addressed in code: scopes strict check to
SCM URLs only, non-SCM keeps URIPathDescriptor.sameSite() — no MSITE-600
regression. 3/ Test javadoc: valid — references URIPathDescriptor.sameSite()
but SCM URLs compare via isSameRepositoryPath; reword javadoc. 4/ IPv6 bracket:
valid — indexOf(':') inside brackets breaks; add bracket guard before SCP
conversion or skip IPv6 case. 5/ MSITE-600 regression: invalid — isSameSite()
doesn't exist; design deliberately scopes strict check to SCM URLs only;
non-SCM URLs retain original semantics. Summary: fixes 1,3,4 worth it; 2
already handled; 5 misunderstanding of design.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
