gnodet commented on PR #12974: URL: https://github.com/apache/maven/pull/12974#issuecomment-5479681882
> Also this is not a complete fix for Windows. Windows reserves a number of file names at the word -- not character level. If any of these showed up as a group ID or artifact ID or something else we try to create a file for in the local repo, Windows developers would have a bad day: > > ``` > CON (Console) > PRN (Printer) > AUX (Auxiliary device) > NUL (Null device) > COM1 through COM9 (Serial communication ports) > LPT1 through LPT9 (Parallel printer ports) > ``` I don't think this is an issue. It's only used to read the pom file relative to an existing pom.xml. And the goal of the previous PR was to reject known invalid paths before they cause an unwanted exception while constructing `new Path(xxx)`. We don't necessarily want to verify that the path points to a valid directory or POM file, this is done later when loading the model. We just want to make sure that it _looks like_ a valid path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
