Copilot commented on code in PR #990:
URL: https://github.com/apache/maven-enforcer/pull/990#discussion_r3896012929
##########
maven-enforcer-plugin/src/it/projects/enforce-bytecode-version-excluded-deps/pom.xml:
##########
@@ -37,8 +37,11 @@ under the License.
<enforceBytecodeVersion>
<maxJdkVersion>1.5</maxJdkVersion>
<excludes>
-
<exclude>org.mindrot:jbcrypt:*:*</exclude>
+
<exclude>*:*</exclude>
</excludes>
+ <includes>
+
<include>com.google.code.findbugs:jsr305</include>
+ </includes>
</enforceBytecodeVersion>
Review Comment:
The PR description mentions regression coverage for both “excludes-only
configuration” and “include overrides”, but this IT project now configures both
<excludes> and <includes> (so it no longer exercises the excludes-only case
reported in #985). Consider either adding a second IT scenario that uses only
<excludes> (no <includes>) or updating the PR description to match the actual
test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
