mbien commented on code in PR #766:
URL: https://github.com/apache/maven-indexer/pull/766#discussion_r3918334878
##########
indexer-core/src/main/java/org/apache/maven/index/DefaultIteratorResultSet.java:
##########
@@ -109,9 +110,10 @@ protected DefaultIteratorResultSet(
this.matchHighlightRequests = request.getMatchHighlightRequests();
+ // TODO list never read?
List<MatchHighlightRequest> matchHighlightRequests = new ArrayList<>();
for (MatchHighlightRequest hr : request.getMatchHighlightRequests()) {
- Query rewrittenQuery =
hr.getQuery().rewrite(indexSearcher.getIndexReader());
+ Query rewrittenQuery = hr.getQuery().rewrite(indexSearcher);
matchHighlightRequests.add(new
MatchHighlightRequest(hr.getField(), rewrittenQuery, hr.getHighlightMode()));
}
Review Comment:
this section appears to be a no-op. Maybe it was meant to populate the field
above instead of the variable with the same name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
