desruisseaux commented on code in PR #508:
URL: https://github.com/apache/maven-jar-plugin/pull/508#discussion_r3921602001
##########
src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java:
##########
@@ -140,24 +144,52 @@ public abstract class AbstractJarMojo implements
org.apache.maven.api.plugin.Moj
* Timestamp for reproducible output archive entries.
* This is either formatted as ISO 8601 extended offset date-time
* (e.g. in UTC such as '2011-12-03T10:15:30Z' or with an offset
'2019-10-05T20:37:42+06:00'),
- * or as an integer representing seconds since the epoch
- * (like <a
href="https://reproducible-builds.org/docs/source-date-epoch/";>SOURCE_DATE_EPOCH</a>).
+ * or as an integer representing seconds since the Java epoch (January
1st, 1970).
+ * If not configured or disabled,
+ * the <a
href="https://reproducible-builds.org/docs/source-date-epoch/";>SOURCE_DATE_EPOCH</a>
+ * environment variable is used as a fallback value,
+ * to ease forcing Reproducible Build externally when the build has not
enabled it natively in <abbr>POM</abbr>.
+ *
+ * <p>This property is supported only in Java 19 or later.</p>
*
* @since 3.2.0
*/
@Parameter(defaultValue = "${project.build.outputTimestamp}")
protected String outputTimestamp;
/**
- * Whether to detect multi-release JAR files.
- * If the JAR contains the {@code META-INF/versions} directory it will be
detected as a multi-release JAR file
- * ("MRJAR"), adding the {@code Multi-Release: true} attribute to the main
section of the JAR {@code MANIFEST.MF}.
+ * Whether to detect multi-release <abbr>JAR</abbr> files.
+ * If the JAR contains the {@code META-INF/versions} directory, it is
detected as a multi-release JAR file.
Review Comment:
I do not put `<abbr>` everywhere. We are often asked to avoid abbreviations,
or at least give their meaning. I put some `<abbr>` in prominent occurrences of
the abbreviation and omit `<abbr>` elsewhere. I agree that `<abbr>` without
`title` is not very useful, but I tend to omit `title` because it could be
automatized (even if this is not the case yet).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
