slachiewicz opened a new pull request, #1094: URL: https://github.com/apache/maven-doxia/pull/1094
Marks the four hooks from #1074 that will be retyped to `SinkEventAttributes` in the next major. The point is that the retype is a silent break: an override compiled against the old signature stops overriding and is simply never called again, with nothing failing at build or run time. A deprecation warning now is the only notice a downstream parser author gets. Of the five hooks #1074 lists, only `consecutiveSections` was already marked. Two things worth a reviewer's attention: `getAttributesFromParser` is the weakest of the four. Its problem is only the return type, and all seven call sites use nothing beyond the interface (`getAttribute`, `addAttribute`, `removeAttribute`), so the eventual retype needs no caller changes at all. Nothing in the repo overrides it either. So this one warns correct code to protect a hypothetical overrider — happy to drop it from the set if you would rather. Deprecating `baseStartTag(String, ...)` and `baseEndTag(String, ...)` also silences the pre-existing `impl.SinkEventAttributeSet` warnings inside their bodies, because the JLS does not warn for uses within a deprecated declaration. doxia-core goes from 84 deprecation warnings to 18. Nothing was fixed; the warnings moved out of view. Flagging it so it is not mistaken for progress. Verified: `mvn verify` green (japicmp, RAT, checkstyle, all tests); `mvn javadoc:javadoc` green with 0 errors and no warning on any added block; deprecation-warning counts compared against master built to the identical reactor point. Part of #1074 *This change was created with AI assistance.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
