gnodet commented on code in PR #13036:
URL: https://github.com/apache/maven/pull/13036#discussion_r3930200150
##########
api/maven-api-core/src/main/java/org/apache/maven/api/services/DependencyCoordinatesFactoryRequest.java:
##########
@@ -77,10 +77,10 @@ static DependencyCoordinatesFactoryRequest build(
.session(requireNonNull(session, "session cannot be null"))
.groupId(requireNonNull(coordinates, "coordinates cannot be
null")
.getGroupId())
Review Comment:
Same missed conversion — `getGroupId()` left as-is while the rest of the
chain uses noun-style.
```suggestion
.groupId())
```
##########
api/maven-api-core/src/main/java/org/apache/maven/api/services/ArtifactCoordinatesFactoryRequest.java:
##########
@@ -97,10 +97,10 @@ static ArtifactCoordinatesFactoryRequest build(@Nonnull
Session session, @Nonnul
return ArtifactCoordinatesFactoryRequest.builder()
.session(requireNonNull(session, "session"))
.groupId(requireNonNull(coordinates,
"coordinates").getGroupId())
Review Comment:
`getGroupId()` on the `requireNonNull()` return was not converted to
`groupId()`, while `artifactId()`, `classifier()`, `versionConstraint()`, and
`extension()` on the same object (next lines) were.
```suggestion
.groupId(requireNonNull(coordinates,
"coordinates").groupId())
```
##########
api/maven-api-core/src/main/java/org/apache/maven/api/services/DependencyCoordinatesFactoryRequest.java:
##########
@@ -89,12 +89,12 @@ static DependencyCoordinatesFactoryRequest build(@Nonnull
Session session, @Nonn
return builder()
.session(requireNonNull(session, "session cannot be null"))
.groupId(requireNonNull(dependency, "dependency").getGroupId())
Review Comment:
Same pattern — `getGroupId()` not converted.
```suggestion
.groupId(requireNonNull(dependency, "dependency").groupId())
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
