slachiewicz opened a new pull request, #990:
URL: https://github.com/apache/maven-wagon/pull/990

   Ports #986 to `master`, which carries the same compile scopes.
   
   The JSR-330 migration added `javax.inject` and `org.eclipse.sisu.inject` to 
`wagon-providers/pom.xml` at compile scope, so every consumer of a provider 
inherits them. Scoping both `provided` keeps them on the compile and test 
classpaths, and off the transitive one.
   
   Any container that can load a wagon supplies both already. Wagon resolves 
sisu through maven-parent 49 at 1.0.1 while Maven ships 1.1.0, so the inherited 
copy was only ever a version to resolve away.
   
   `dependency:tree` for a project depending on `wagon-file` and 
`wagon-webdav-jackrabbit` carries no `sisu`, `javax.inject` or `guice` entry 
after this change.
   
   The commit is a clean cherry-pick of cea03168.
   
   Verified: `mvn clean install` with `wagon-ssh-external` excluded -> BUILD 
SUCCESS. Two suites do not pass in my environment and fail identically on stock 
`master`, so they are untouched by this change:
   
   - `wagon-ssh-external` reports 57 tests, 3 failures, 21 errors both with and 
without the commit (`ssh: connect to host localhost` exit 255; no local sshd).
   - `HugeFileDownloadTest` needs about 4 GB of scratch space for a 2 GB 
fixture, and my disk had 1.4 GB free. The 3.x line halved that fixture in 
3fca786f; `master` has no equivalent commit, so this test is heavier here.
   
   Both run in CI, which is the gate for them.
   
   *This change was created with AI assistance.*
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to