pan3793 commented on PR #849: URL: https://github.com/apache/maven-shade-plugin/pull/849#issuecomment-5539950006
Log level is not an adequate switch here. Maven has no per-plugin log level on the command line; `-X` floods the build with thousands of debug lines from every plugin and Maven core to recover five lines of output. Telling users to diff a `-X` log is not a workable answer for something they read on every release build. And the claim that this avoids complexity is not borne out downstream: MSHADE-479 did not remove complexity, it moved it onto every user who relied on the output. Apache Kyuubi and Apache Spark stayed on 3.6.0 and now explicitly override the ASM version to keep Java 25 compatibility, solely to preserve this output. Apache Flink upgraded but restores the old behavior by configuring a plugin-specific logger level in its CI pipeline. Three major projects maintaining workarounds is strictly more complexity than one boolean parameter in the plugin. This is also not "combinatorial explosion". It is one flag restoring behavior the plugin shipped for ~15 years, following a well-established convention: maven-compiler-plugin, maven-javadoc-plugin, and maven-dependency-plugin all have `verbose`. The messages matter because shading is not transparent: the include/exclude list is how users audit the jar they publish. That is informational output about the produced artifact, not debug noise. Default stays `false`, so users who wanted a quiet build lose nothing. A default-off opt-in that unblocks multiple downstream projects is not complexity worth vetoing. Given the demand in #756, on #233, and the downstream impact above, I ask that this PR be reopened and the decision deferred until more maintainers and affected users have weighed in, rather than settled by a single early veto. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
